[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia marked an inline comment as done.
Anastasia added inline comments.


================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:3880
+        ToType, From->getType(), From, Action);
+    // assert(Diagnosed && "failed to diagnose bad conversion");
+    (void)Diagnosed;
----------------
rjmccall wrote:
> This assertion seems important; can we make it work?
Currently DiagnoseAssignmentResult returns true only for `Incompatible` , However we can change it to return true for all `Incompatibel*` in C++ mode. So yes it should be doable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74116/new/

https://reviews.llvm.org/D74116