[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

Oh god, this code is a mess, so many knobs, and apparently I made it worst in the past sorry for that :D

I totally understand if you want to make minimal changes to the code like this, but it would be great to simplify it a little bit without regressing too much, currently there is a knob for function locals and then another for parameters in declarations, then there is an implicit conditioning for function definitions.
I would say it would be sensible to only have `IndexFunctionLocals` as an option and do full indexing of parameters, both in declarations and definitions if it is present (assuming this doesn't result in real regressions in the client code), but it is also OK to leave it as it is, since the mess is beyond the scope of this patch.

But if you leave it as it is, I believe we'll still be missing some references to decls inside default arguments in clangd, for example:

a.h:

  int var = 2;
  void foo(int x = var);

a.cc

  void foo(int x) {
    va^r = x;
  }

clangd won't have the reference occuring in default arg inside the index, as preambles are not indexed with `IndexParametersInDeclarations` option turned on.



================
Comment at: clang/lib/Index/IndexDecl.cpp:102
         auto *DC = Parm->getDeclContext();
+        IndexDefaultParmeterArgument(Parm, Parent);
         if (auto *FD = dyn_cast<FunctionDecl>(DC)) {
----------------
this should move into the `else` clause down below, otherwise it would end up being indexed twice


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74610/new/

https://reviews.llvm.org/D74610