[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

Nikita Popov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 16 08:56:57 PST 2020


nikic added a comment.

Tried what happens if the copy constructor is deleted: https://gist.github.com/nikic/1e6ab5bbf42cfe48e7b848e60a2df180 It looks like the referenced occurrence in DIBuilder was the only place that was using the copy constructor "for good reason", most of the other uses either copy the whole IRBuilder where they just want to pass a reference or copy the whole IRBuilder where they really just want an InsertPointGuard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73835/new/

https://reviews.llvm.org/D73835





More information about the cfe-commits mailing list