[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp
Jonathan Roelofs via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Feb 16 08:21:38 PST 2020
jroelofs marked an inline comment as done.
jroelofs added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.h:26
+/// For the user-facing documentation see:
+/// http://clang.llvm.org/extra/clang-tidy/checks/bugprone-suspicious-include.html
+class SuspiciousIncludeCheck : public ClangTidyCheck {
----------------
FIXME: still need to write docs for this.
================
Comment at: clang-tools-extra/clang-tidy/misc/NoIncludeCPPCheck.cpp:50
+
+ (void)FilenameRange;
+ (void)File;
----------------
njames93 wrote:
> I have a feeling this is to suppress some unused parameter linting check. If it is then it should be removed as unused parameters in an overridden function shouldn't emit a warning.
> Same for below.
>
> Side note: File a bug with whichever linter tool gave you that warning (if there was one).
>
Sorry, did this out of habit. Indeed it isn't actually needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74669/new/
https://reviews.llvm.org/D74669
More information about the cfe-commits
mailing list