[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC
Kirill Bobyrev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 14 03:00:27 PST 2020
kbobyrev accepted this revision.
kbobyrev added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:345
+
+ SPAN_ATTACH(Tracer, FileAndOccurrences.first(),
+ static_cast<int64_t>(Ranges.size()));
----------------
hokein wrote:
> kbobyrev wrote:
> > A tracer message here would be helpful!
> the message now would be the <filename, num_of_ranges> and under the `FindOccurrencesOutsideFile` span, I think it is clear enough?
Okay, sounds good!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74395/new/
https://reviews.llvm.org/D74395
More information about the cfe-commits
mailing list