[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:98
+  case SK::TemplateTypeParm:
+  case SK::TemplateTemplateParm:
     return CompletionItemKind::Class;
----------------
I think these two should belong to `CompletionItemKind::TypeParameter`?


================
Comment at: clang/lib/Index/IndexSymbol.cpp:360
       break;
+    case Decl::TemplateTypeParm:
+      Info.Kind = SymbolKind::TemplateTypeParm;
----------------
nit: could we move these newly-added lines above the `case Decl::ClassTemplatePartialSpecialization:`. I think we usually put the `llvm_unreachable` cases at the end of switch statement..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73696/new/

https://reviews.llvm.org/D73696