[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

Thu Feb 13 15:00:25 PST 2020

mibintc added a comment.

In D74436#1875273 <https://reviews.llvm.org/D74436#1875273>, @jsji wrote:

> This is also breaking test-suites in our internal buildbots ..
>
> This change is actually changing the default behavior: if user does NOT supply `-ffp-contract`, it becomes `-ffp-contract=on`.
>
> So this means any code without explicitly add `-ffp-contract=off` will have `-ffp-contract=on`.
>  eg: -O0 will also generate FMA.
>
> Is this intended behavior change?   @mibintc @andrew.w.kaylor

You're right, -O0 shouldn't generate FMA. I'm preparing to revert this now -- just verifying the build.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74436/new/

https://reviews.llvm.org/D74436