[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

Thu Feb 13 12:06:00 PST 2020

tra added a comment.

In D74571#1875002 <https://reviews.llvm.org/D74571#1875002>, @kkwli0 wrote:

> In D74571#1874947 <https://reviews.llvm.org/D74571#1874947>, @JonChesterfield wrote:
>
> > Do the in tree tests all pass with the 10.2 toolchain? That's not exactly the same as whether it works but is the closest approximation we have available.
> >
> > Assuming yes, this patch seems uncontroversial.
>
>
> Yes, in tree tests pass with 10.2.

I do not think it is relevant as those tests don't use CUDA-10.2 specific features yet.

Removing the warning here is similar to claiming that C++ compiler supports C++17 based on it passing C++ tests for c++11.

If OpenMP needs the warning gone, I'm OK with disabling it for openmp compilation, if that's what openmp owners want/need.
The warning should remain enabled otherwise.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74571/new/

https://reviews.llvm.org/D74571