[PATCH] D74447: [Clang] After integrated-cc1, ignore -disable-free when there are more than one job in the queue

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 13 07:30:20 PST 2020


thakis added a comment.

I forgot another reason why "only do cc1 with a single TU" might be a good idea: In case crash recovery turns out to not work in all cases with in-process cc1, we could add a signal handler that on crash make the driver exec() itself with -fno-integrated-cc1 added, so that the crash is then processed again with out-of-process cc1. (At least on non-Windows.) I prototyped this at https://github.com/nico/hack/blob/master/crash_signal.cc a while ago (in a standalone program). This only works if the crashing cc1 invocation is the first thing the driver does.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74447/new/

https://reviews.llvm.org/D74447





More information about the cfe-commits mailing list