[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

Thu Feb 13 05:50:05 PST 2020

teemperor added a comment.

In D74542#1874201 <https://reviews.llvm.org/D74542#1874201>, @martong wrote:

> Looks good to me! Thanks!
>  Adding @balazske as another reviewer though. He worked on something related to this, where we also experienced an assert in `isBeforeInTranslationUnit`.

IIRC the analyser is using the isBeforeInTranslationUnit for the error paths so that's how the X-TU analysis could hit this situation (if the error path is spanning Decls from different files). But that's mostly speculation.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74542/new/

https://reviews.llvm.org/D74542