[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

[Yvan Roux via Phabricator via cfe-commits]

yroux marked an inline comment as done.
yroux added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:1159
+  MF.getProperties().reset(MachineFunctionProperties::Property::IsSSA);
+  MF.getProperties().set(MachineFunctionProperties::Property::NoPHIs);
+  MF.getProperties().set(MachineFunctionProperties::Property::NoVRegs);
----------------
yroux wrote:
> samparker wrote:
> > Looks like these should these be set in getRequiredProperties.
> Maybe @paquette can comment on that
Just to clarify, these are properties which are given to the created outlined functions and are required by the next passes (such as Constant Island), thus this is not part of getRequiredProperties


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57054/new/

https://reviews.llvm.org/D57054