[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang
Johannes Doerfert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 12 18:02:02 PST 2020
jdoerfert added a comment.
One question (below) otherwise this looks good.
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:358
+__OMP_DEFAULT_KIND(shared, 3)
+__OMP_DEFAULT_KIND(unknown, 4)
+
----------------
Why 2, 3, 4? Do we really need to specify the value here? If not, remove the `Value` part everywhere, or replace it with `unsigned(Enum)`, and we should be fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74513/new/
https://reviews.llvm.org/D74513
More information about the cfe-commits
mailing list