[PATCH] D74483: [AArch64] Add Cortex-A34 Support for clang and llvm

[Sjoerd Meijer via Phabricator via cfe-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks like the usual business of adding a cpu to me, with one nit inlined that can be fixed before committing.

Looks like you're doing the LLVM part separately. Now with the monorepo you could have conveniently done it in one patch, but nothing wrong with doing it separately.  You could have linked to the llvm part here if that is ready, which would be nice to get an overview.



================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:784
   EXPECT_TRUE(testAArch64CPU(
+      "cortex-a34", "armv8-a", "crypto-neon-fp-armv8",
+      AArch64::AEK_CRC | AArch64::AEK_SIMD |
----------------
nit: this looks the same as the a35. Would be better to keep the same order of arch extension and also the formatting (to make it easier to eyeball differences).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74483/new/

https://reviews.llvm.org/D74483