[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

Wed Feb 12 06:22:21 PST 2020

aaron.ballman added a comment.

In D73852#1872104 <https://reviews.llvm.org/D73852#1872104>, @aaron.ballman wrote:

> All this said, I am comfortable reverting this back out of the 10.0 branch while we consider it harder. It does not seem so critical that we can't take time to discuss it further.

Ah, this may not be in the 10.0 branch yet anyway. I mostly would prefer to avoid churn where we put it in, pull it out, and put it back in, if there's a way to salvage the feature by addressing issues post-commit as we typically do. Obviously, if there's sufficient justification to pull it out and not put it back in, that's the solution we should pick.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73852/new/

https://reviews.llvm.org/D73852