[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 11 16:55:49 PST 2020
efriedma added a comment.
I just ran into this warning, and I think there's a bit of a discoverability problem related to the width of tabs and -ftabstop. If you have mixed tabs and spaces, and you've correctly specified the tab stop width with -ftabstop, everything works fine. If you haven't specified -ftabstop, you get a warning, and the issue isn't obvious. Depending on your editor settings, the code might look fine at first glance, and the warning text doesn't mention -ftabstop at all. Maybe there's something that could be improved here, if we're printing a warning for two lines with mismatched indentation styles?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71037/new/
https://reviews.llvm.org/D71037
More information about the cfe-commits
mailing list