[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

Tue Feb 11 14:22:38 PST 2020

jdoerfert added a comment.

In D74372#1870620 <https://reviews.llvm.org/D74372#1870620>, @vsk wrote:

> Thanks :). IIRC `check-clang` is enough to exercise the relevant code path, as we get an assert in CodeExtractor without the workaround. (side note: please don't take my comments here as blocking, I just wanted to see if we could delete some cruft)

Can you verify I deleted the workaround? I was not sure if the workaround is all of it or only the OMP... part.
I run the test you mentioned w/ and w/o the debug flag you mentioned in the PR, both times it passes w/o assertion:

  PASS: Clang :: OpenMP/parallel_codegen.cpp 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74372/new/

https://reviews.llvm.org/D74372