[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 11 12:51:52 PST 2020


ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:15293
+      //  TypeDecorCnt for B: 0
+      if (Depth <= TypeDecorCnt) {
+        RelevantExpr = cast<Expr>(DRE);
----------------
cchen wrote:
> ABataev wrote:
> > The check is really bad. If you want to handle something like `*(B+x)` better to treat, say, `B` as the base and `x` as the index and, thus, treat the whole expression as something like `B[x]`
> I don't understand how to do this, is there any sample code that I can learn from? Thanks
Not sure we have something like this, need to invent something new if we want to support lvalues in full. Or discard it as unsupported if we're unable to support it properly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72811/new/

https://reviews.llvm.org/D72811





More information about the cfe-commits mailing list