[PATCH] D74260: Change default relocation model for hexagon when triple includes musl
Brian Cain via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 11 07:41:22 PST 2020
bcain added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:923
+ return ((getTriple().isAndroid() && !getTriple().isAndroidVersionLT(16)) ||
+ getTriple().isMusl() || getSanitizerArgs().requiresPIE()) &&
+ getTriple().getArch() != llvm::Triple::hexagon;
----------------
But if
```
getSanitizerArgs().requiresPIE() && getTriple().getArch() == llvm::Triple::hexagon
```
.... then the `!= hexagon` takes precedence? Seems like "sanitizer requires PIE" should, right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74260/new/
https://reviews.llvm.org/D74260
More information about the cfe-commits
mailing list