[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

Alexandre Ganea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 11 07:32:30 PST 2020


aganea marked 2 inline comments as done.
aganea added a comment.

Side-note: Perhaps we would need to do the same as this patch, for calls to `::abort()`?



================
Comment at: llvm/include/llvm/Support/Process.h:205
+
+  /// When integrated-cc1 is disabled, terminate the current program.
+  /// When integrated-cc1 is enabled, terminates execution of the current
----------------
hans wrote:
> Could the comment be phrased in terms of CrashRecoveryContext instead of integrated-cc1, which is a Clang thing?
Done in the commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73742/new/

https://reviews.llvm.org/D73742





More information about the cfe-commits mailing list