[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

Tue Feb 11 00:00:27 PST 2020

djtodoro added inline comments.

================
Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:61
 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed)
+HANDLE_DI_FLAG((1 << 30), ConstExpr)

----------------
We are almost out of space here... I wouldn't add any additional flag here before we do necessary refactoring. 

As we discussed, it makes sense moving the function-related flags into the existing `DISPFlags`. In addition, we may want to introduce something like `DIVarFlags`, and move the variable-related flags into that.

Also, we need to pay attention on the bitcode compatibility as well. Back then, I have implemented something similar here: https://reviews.llvm.org/D59288, so it can be used as a reference.

I think we have to do it first, as a preparation patch for this one.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73261/new/

https://reviews.llvm.org/D73261