[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

What is the motivation for adding a best effort `-fsemantic-interposition`? Was there anything wrong with our previously unstated project policy of ignoring this complexity and surviving without this mode? Less modes -> less conditional soup...



================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:852
 
   // A definition cannot be preempted from an executable.
   if (!GV->isDeclarationForLinker())
----------------
We now come here for shared objects in most cases: most definitions are assumed to be dso_local and most declarations are assumed to be in another DSO. Please update the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73865/new/

https://reviews.llvm.org/D73865