[PATCH] D72241: [clang-tidy] new altera single work item barrier check

Frank Derry Wanye via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 10 19:43:00 PST 2020


ffrankies updated this revision to Diff 243717.
ffrankies marked 3 inline comments as done.
ffrankies added a comment.

Implemented requested changes by @Eugene.Zelenko

- Changed `auto` to `const auto *`
- Changed `if(IsNDRange == true)` to `if(IsNDRange)`
- Highlighted 1600 with single back-quotes
- Added link to https://reviews.llvm.org/D66564 as a dependency in Summary (is there someplace else I can refer to that as a dependency?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72241/new/

https://reviews.llvm.org/D72241

Files:
  clang-tidy/CMakeLists.txt
  clang-tidy/ClangTidyForceLinker.h
  clang-tidy/altera/AlteraTidyModule.cpp
  clang-tidy/altera/CMakeLists.txt
  clang-tidy/altera/SingleWorkItemBarrierCheck.cpp
  clang-tidy/altera/SingleWorkItemBarrierCheck.h
  docs/ReleaseNotes.rst
  docs/clang-tidy/checks/altera-single-work-item-barrier.rst
  docs/clang-tidy/checks/list.rst
  docs/clang-tidy/index.rst
  test/clang-tidy/checkers/altera-single-work-item-barrier.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72241.243717.patch
Type: text/x-patch
Size: 23425 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200211/c16db25a/attachment-0001.bin>


More information about the cfe-commits mailing list