[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 10 07:39:14 PST 2020


efriedma requested changes to this revision.
efriedma added a comment.
This revision now requires changes to proceed.

For the clang change, we should do something like D72579 <https://reviews.llvm.org/D72579>, not explicitly check for a specific target in target-independent code.

For compiler-rt, are you really disabling COMPILER_RT_EXCLUDE_ATOMIC_BUILTIN?  Are you sure you understand the implications of that?

I'm also curious: what part of clang is calling __atomic_is_lock_free?  I can't find any code in LLVM that calls it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71600/new/

https://reviews.llvm.org/D71600





More information about the cfe-commits mailing list