[PATCH] D73845: [Gnu toolchain] Look at standard GCC multilib/multiarch paths by default

[Kristina Brooks via Phabricator via cfe-commits]

kristina added a comment.

I feel like in this specific case it may be worth splitting this into two patches:

- Factoring certain stuff out of `Linux.cpp` into `Gnu.(cpp|h)`.
- Adding that machinery to `Hurd.cpp` with related tests.

Also forgive me if I'm wrong but isn't Hurd only limited to one GCC target triple (`i386-gnu`) for the time being? A lot of the factored out bits seem to be still only applicable to Linux at a glance, in which case I'm not entirely sure of the rationale behind most of the refactoring. Since most people (including me) are unlikely to be intimately familiar with the directory/library layout on Hurd, is it possible to provide some more background on the Hurd-specific side of the patch?



================
Comment at: clang/lib/Driver/ToolChains/Gnu.h:324
+                            const std::string &OSLibDir, path_list &Paths);
+  void AddGCCClangSystemIncludeArgs(const llvm::opt::ArgList &DriverArgs,
+                                    llvm::opt::ArgStringList &CC1Args) const;
----------------
Maybe rename `AddGCCClangSystemIncludeArgs` to `AddMultilibIncludeArgs` for brevity/clarity?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73845/new/

https://reviews.llvm.org/D73845