[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 7 11:40:06 PST 2020


erik.pilkington marked an inline comment as done.
erik.pilkington added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:3687
 
-  args.add(EmitAnyExprToTemp(E), type);
 }
----------------
thegameg wrote:
> Is there any other use of `EmitAnyExprToTemp` that can benefit from this?
Right now, the only other user of that function is `CodeGenFunction::EmitStmtExprLValue`, which doesn't seem all that interesting. There are a lot of places that do create temporary allocas that would be worth looking into in the future though. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74094/new/

https://reviews.llvm.org/D74094





More information about the cfe-commits mailing list