[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 7 08:18:17 PST 2020


ABataev added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:3414-3416
+def fsycl : Flag<["-"], "fsycl">, Group<sycl_Group>, Flags<[NoArgumentUnused, CoreOption]>,
   HelpText<"Enable SYCL kernels compilation for device">;
+def fno_sycl : Flag<["-"], "fno-sycl">, Group<sycl_Group>, Flags<[NoArgumentUnused, CoreOption]>,
----------------
bader wrote:
> ABataev wrote:
> > These flags should not be ignored, `NoArgumentUnused` should be applied to this flags.
> Do you mean "`NoArgumentUnused` should **not** be applied"?
Yes, missed `not`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72857/new/

https://reviews.llvm.org/D72857





More information about the cfe-commits mailing list