[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

[Erik Pilkington via Phabricator via cfe-commits]

erik.pilkington planned changes to this revision.
erik.pilkington marked an inline comment as done.
erik.pilkington added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:3697
+
+  args.add(EmitAnyExpr(E, ArgSlot), type);
 }
----------------
rjmccall wrote:
> If the argument type has a C++ destructor, will we end its lifetime before we call destructors at the end of the full-expression?
Yeah, this is broken :/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74094/new/

https://reviews.llvm.org/D74094