[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 6 11:37:37 PST 2020


rsmith added a comment.

In D73967#1861757 <https://reviews.llvm.org/D73967#1861757>, @erichkeane wrote:

> Extended-vector types don't really make sense for non-powers-of-two (plus have some odd gotchas when it comes to vectors of i1 for example), so I've added a test that shows that this is rejected.


OK, that seems fine to me.

> _Complex _ExtInt(N) is rejected when parsing _Complex.  It doesn't seem to make sense to me to support them, so I've added a test that shows it is invalid.  Do you disagree?

We allow _Complex T for integral types T in general, so this seems inconsistent. Are there problems supporting this? Is it just a parser limitation or something deeper? If there's some reason it doesn't naturally work (as there is for at least non-power-of-two-sized integers in vectors) then rejecting it seems fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73967/new/

https://reviews.llvm.org/D73967





More information about the cfe-commits mailing list