[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

Thu Feb 6 08:59:58 PST 2020

bader marked an inline comment as done.
bader added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031

+  if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) {
+    A->render(Args, CmdArgs);
+  } else if (IsSYCL) {
----------------
ABataev wrote:
> bader wrote:
> > ABataev wrote:
> > > Should this option also be controlled by `-fsycl`? 
> > Make sense to me.
> > @Ruyk, are you okay with that?
> > 
> > @ABataev, do you have any suggestion on what we should we do if `-sycl-std` option is used w/o `-fsycl`? Ignore or report warning/error?
> Mark this option as `NoArgumentUnused` (so the compiler does not report unused option) and ignore it.
Ok. Is it okay if we add one more flag - `CoreOption`? We'd like enable these options fir `clang-cl` as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72857/new/

https://reviews.llvm.org/D72857