[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version
Alexey Bader via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 6 08:32:56 PST 2020
bader marked 7 inline comments as done.
bader added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031
+ if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) {
+ A->render(Args, CmdArgs);
+ } else if (IsSYCL) {
----------------
ABataev wrote:
> Should this option also be controlled by `-fsycl`?
Make sense to me.
@Ruyk, are you okay with that?
@ABataev, do you have any suggestion on what we should we do if `-sycl-std` option is used w/o `-fsycl`? Ignore or report warning/error?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72857/new/
https://reviews.llvm.org/D72857
More information about the cfe-commits
mailing list