[PATCH] D74125: [clangd] Set "spelled" flag for constructor references.

[Haojian Wu via Phabricator via cfe-commits]

hokein marked 3 inline comments as done.
hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:597
+        bool IsTargetKind = NameKind == DeclarationName::Identifier ||
+          NameKind == DeclarationName::CXXConstructorName;
+        bool Spelled = IdentifierToken && IsTargetKind &&
----------------
kadircet wrote:
> drive-by: what about destructors?
we aren't interested in destructors (particularly the `~`) as there is a `Foo` typeloc in "~[[Foo]]". 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74125/new/

https://reviews.llvm.org/D74125