[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

In D73675#1858688 <https://reviews.llvm.org/D73675#1858688>, @shafik wrote:

> I forgot to mention this earlier but LLDB is a major user of the `ASTImporter` and so in general it is a good idea to run `check-lldb` as well.


I ran the LLDB tests on Linux, but I get 42 failures:
https://reviews.llvm.org/P8192
If I revert my change, I get the same 42 failures.

I debugged the first test, and it doesn't run because it's trying to use libc++.so, but it's not on the library path:

  $ ./a.out
  ./a.out: error while loading shared libraries: libc++.so.1: cannot open shared object file: No such file or directory

I can add the `lib` directory inside my checkout to LD_LIBRARY_PATH and it will run:

  $ LD_LIBRARY_PATH="$HOME/llvm-project/build/lib" ./a.out
  Test

So, the fix is straightforward, but I think it might take an expert to figure out exactly where to put that logic. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73675/new/

https://reviews.llvm.org/D73675