[PATCH] D69868: Allow "callbr" to return non-void values

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added a comment.

I think this is fine, but want to hear from @jyknight and @rnk.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:1039
+      auto &Last = BB->back();
+      for (unsigned i = 0; i < Last.getNumOperands(); ++i) {
+        MachineOperand &MO = Last.getOperand(i);
----------------
`for (const MachineOperand &MO : Last.operands()) {`



================
Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:1062
+    for (auto &MI : *CopyBB) {
+      for (unsigned i = 0; i < MI.getNumOperands(); ++i) {
+        const MachineOperand &MO = MI.getOperand(i);
----------------
`for (const MachineOperand &MO : MI.operands()) {`



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69868/new/

https://reviews.llvm.org/D69868