[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 5 02:38:54 PST 2020
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
================
Comment at: clang-tools-extra/clangd/SourceCode.cpp:1139
+ // Double check that this is an actual protobuf header.
+ if (!SM.getBufferData(FID).startswith(PROTO_HEADER_COMMENT))
+ return false;
----------------
nit: just `return SM.getBufferData(FID).startswith(PROTO_HEADER_COMMENT);`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73780/new/
https://reviews.llvm.org/D73780
More information about the cfe-commits
mailing list