[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.
Michael Liao via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 4 19:08:10 PST 2020
hliao created this revision.
Herald added subscribers: cfe-commits, kristof.beyls.
Herald added a project: clang.
- Similar to other targets, instead of passing a toolchain, a driver argument should be passed into `arm::getARMTargetFeatures` should take a driver argument. Aslo, that routine should honor the specified triple. Refactor `arm::getARMFloatABI` with separate interfaces. One has the original parameters and the other uses the driver and the specified triple.
- That fix an issue when target & features are queried during offload compilation, where the specified triple should be checked instead of that effective triple. Previous failed test is re-enabled.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D74020
Files:
clang/lib/Driver/ToolChains/Arch/ARM.cpp
clang/lib/Driver/ToolChains/Arch/ARM.h
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/Driver/cuda-simple.cu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74020.242503.patch
Type: text/x-patch
Size: 4469 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200205/ea7dd69d/attachment.bin>
More information about the cfe-commits
mailing list