[PATCH] D74004: [analyzer] Move fuchsia.Lock checker to alpha

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun created this revision.
xazax.hun added reviewers: NoQ, haowei.
xazax.hun added a project: clang.
Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware.

After experimenting with it a bit it looks like this is not quite ready yet for Fuchsia. Moving it to alpha until the problems are solved.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74004

Files:
  clang/include/clang/StaticAnalyzer/Checkers/Checkers.td
  clang/test/Analysis/fuchsia_lock.c
  clang/test/Analysis/fuchsia_lock_impl.c


Index: clang/test/Analysis/fuchsia_lock_impl.c
===================================================================
--- clang/test/Analysis/fuchsia_lock_impl.c
+++ clang/test/Analysis/fuchsia_lock_impl.c
@@ -1,4 +1,4 @@
-// RUN: %clang_analyze_cc1 -analyzer-checker=fuchsia.Lock -verify %s
+// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.fuchsia.Lock -verify %s
 // expected-no-diagnostics
 typedef int spin_lock_t;
 
Index: clang/test/Analysis/fuchsia_lock.c
===================================================================
--- clang/test/Analysis/fuchsia_lock.c
+++ clang/test/Analysis/fuchsia_lock.c
@@ -1,4 +1,4 @@
-// RUN: %clang_analyze_cc1 -analyzer-checker=fuchsia.Lock -verify %s
+// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.fuchsia.Lock -verify %s
 
 typedef int spin_lock_t;
 typedef int zx_status_t;
Index: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td
===================================================================
--- clang/include/clang/StaticAnalyzer/Checkers/Checkers.td
+++ clang/include/clang/StaticAnalyzer/Checkers/Checkers.td
@@ -109,6 +109,7 @@
 def NonDeterminismAlpha : Package<"nondeterminism">, ParentPackage<Alpha>;
 
 def Fuchsia : Package<"fuchsia">;
+def FuchsiaAlpha : Package<"fuchsia">, ParentPackage<Alpha>;
 
 //===----------------------------------------------------------------------===//
 // Core Checkers.
@@ -1464,6 +1465,10 @@
   HelpText<"A Checker that detect leaks related to Fuchsia handles">,
   Documentation<HasDocumentation>;
 
+}
+
+let ParentPackage = FuchsiaAlpha in {
+
 def FuchsiaLockChecker : Checker<"Lock">,
   HelpText<"Check for the correct usage of locking APIs.">,
   Dependencies<[PthreadLockBase]>,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74004.242452.patch
Type: text/x-patch
Size: 1692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200205/4a4c7cb6/attachment-0001.bin>