[PATCH] D73993: [analyzer] Fix a couple of bugs in HTML report generation.
Csaba Dabis via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 4 15:27:43 PST 2020
Charusso added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:925
HighlightRange(R, LPosInfo.first, Range);
- }
}
----------------
Here the gray highlighting goes, so the `PopUpRanges` store whether we have already highlighted the range and we early-continue. The cool thing is, we do not check for intersections because the pop-up range has a smaller scope than the entire expression's gray range so the HTML handles the colors/mouse-hover for us. In case of macro pop-ups the coloring and-or pop-upping was already buggy, they are handled differently, where I have not found such a cool workaround.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73993/new/
https://reviews.llvm.org/D73993
More information about the cfe-commits
mailing list