[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked 2 inline comments as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:17254
+        SourceLocation(), Context.getTranslationUnitDecl());
+  }
 
----------------
rjmccall wrote:
> yaxunl wrote:
> > rjmccall wrote:
> > > Thanks, this looks a lot better.
> > > 
> > > Should this be moved to SemaOpenMP.cpp (and renamed to be OpenMP-specific), or do you think it's going to be useful in other modes?
> > It is not just for OpenMP. Deferred diagnostics are also emitted by CUDA/HIP.
> Okay.  Can it go in Sema.cpp next to the other overload of `emitDeferredDiags`, then?  There isn't really much purpose to it being in this file.
will do when committing. thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70172/new/

https://reviews.llvm.org/D70172