[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

Tue Feb 4 03:14:26 PST 2020

Anastasia added a comment.

In D73360#1852147 <https://reviews.llvm.org/D73360#1852147>, @rjmccall wrote:

> If it's reasonable to persist the failure kind, that would probably be good, but it might be a lot of work.

I have looked at it earlier and it indeed affects a lot of Sema in C++ mode. Besides amount of work I am not sure I understand the flow enough to come up with a good approach.

Maybe we can finalize this review first to fix the regression. Because I would like it to be ported to the release 10 branch too. Then I can spend some time to see if I can come up with something better for the diagnostic too. :)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73360/new/

https://reviews.llvm.org/D73360