[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI
Dave Green via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 3 10:51:18 PST 2020
dmgreen added a comment.
I added some `This?`'s around, which may or may not be needed too.
================
Comment at: llvm/include/llvm/Support/ARMTargetParser.h:196
unsigned DefaultFPU;
unsigned ArchBaseExtensions;
T ID;
----------------
This?
================
Comment at: llvm/lib/Support/ARMTargetParser.cpp:374
return StringSwitch<unsigned>(CPU)
#define ARM_CPU_NAME(NAME, ID, DEFAULT_FPU, IS_DEFAULT, DEFAULT_EXT) \
----------------
This?
================
Comment at: llvm/lib/Support/ARMTargetParser.cpp:489
static unsigned getAEKID(StringRef ArchExtName) {
for (const auto AE : ARM::ARCHExtNames)
----------------
This?
================
Comment at: llvm/lib/Support/ARMTargetParser.cpp:502
const bool Negated = stripNegationPrefix(ArchExt);
unsigned ID = getAEKID(ArchExt);
----------------
This?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73906/new/
https://reviews.llvm.org/D73906
More information about the cfe-commits
mailing list