[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:3412-3414
+def fsycl : Flag<["-"], "fsycl">, Group<sycl_Group>,
+  HelpText<"Enable SYCL kernels compilation for device">;
+def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group<sycl_Group>, Flags<[CC1Option]>,
----------------
bader wrote:
> ABataev wrote:
> > Better to split this into 2 parts: the first for `-fsycl` and the second for `-sycl-std=`.
> Okay. Just one question: 
> 
> Do you know if it's okay to have two commits per review request (like the first version of the "patch" in this review - it was split as you suggest)? Or I should create two separate review requests?
Separate patches must have separate review requests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72857/new/

https://reviews.llvm.org/D72857