[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 1 19:20:34 PST 2020


MaskRay added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1103
   Opts.XRayIgnoreLoops =
-      Args.hasArg(OPT_fxray_ignore_loops, OPT_fno_xray_ignore_loops, false);
+      Args.hasFlag(OPT_fxray_ignore_loops, OPT_fno_xray_ignore_loops, false);
 
----------------
`Args.hasArg(OPT_fxray_ignore_loops);`

There is no need to check a fno option in cc1, if the option is always enabled/disabled by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73842/new/

https://reviews.llvm.org/D73842





More information about the cfe-commits mailing list