[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 31 07:03:07 PST 2020


martong added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:1168
+  Error Err = Error::success();
+  QualType ToElementType = T->getElementType();
+  Expr *ToSizeExpr = T->getSizeExpr();
----------------
shafik wrote:
> Should this group be using `importChecked` as well?
Yes, this is a good catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73675/new/

https://reviews.llvm.org/D73675





More information about the cfe-commits mailing list