[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 30 17:18:43 PST 2020


dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM, with one style nitpick.



================
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:4049-4051
+    if (!OMD->getBody() || COMD->getReturnType() == OMD->getReturnType()) {
+      return I->second;
+    }
----------------
I think the LLVM style is to leave out these braces.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73208/new/

https://reviews.llvm.org/D73208





More information about the cfe-commits mailing list