[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes
Roland McGrath via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 30 13:06:53 PST 2020
mcgrathr updated this revision to Diff 241560.
mcgrathr added a comment.
builds now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73734/new/
https://reviews.llvm.org/D73734
Files:
clang/lib/Driver/ToolChains/CommonArgs.cpp
Index: clang/lib/Driver/ToolChains/CommonArgs.cpp
===================================================================
--- clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -583,6 +583,12 @@
void tools::linkSanitizerRuntimeDeps(const ToolChain &TC,
ArgStringList &CmdArgs) {
+ if (TC.getTriple().isOSFuchsia()) {
+ // Fuchsia never needs these. Any sanitizer runtimes with system
+ // dependencies use the `.deplibs` feature.
+ return;
+ }
+
// Force linking against the system libraries sanitizers depends on
// (see PR15823 why this is necessary).
CmdArgs.push_back("--no-as-needed");
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73734.241560.patch
Type: text/x-patch
Size: 691 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200130/96068612/attachment.bin>
More information about the cfe-commits
mailing list