[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

[Roland McGrath via Phabricator via cfe-commits]

mcgrathr created this revision.
mcgrathr added a reviewer: phosek.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This is never appropriate on Fuchsia and any future needs for
system library dependencies of compiler-supplied runtimes will
be addressed via `.deplibs` instead of driver hacks.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73734

Files:
  clang/lib/Driver/ToolChains/CommonArgs.cpp


Index: clang/lib/Driver/ToolChains/CommonArgs.cpp
===================================================================
--- clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -583,6 +583,12 @@
 
 void tools::linkSanitizerRuntimeDeps(const ToolChain &TC,
                                      ArgStringList &CmdArgs) {
+  if (Triple.isOSFuchsia()) {
+    // Fuchsia never needs these.  Any sanitizer runtimes with system
+    // dependencies use the `.deplibs` feature.
+    return;
+  }
+
   // Force linking against the system libraries sanitizers depends on
   // (see PR15823 why this is necessary).
   CmdArgs.push_back("--no-as-needed");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73734.241536.patch
Type: text/x-patch
Size: 683 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200130/f38281f1/attachment.bin>