[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter
Arthur O'Dwyer via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 29 17:27:07 PST 2020
Quuxplusone added inline comments.
Herald added a subscriber: rnkovacs.
================
Comment at: clang/lib/AST/ASTImporter.cpp:1152
+ if (Error E = importSeq(ToElementType, ToSizeExpr))
+ return std::move(E);
----------------
As the author of [P1155 "More Implicit Move"](https://wg21.link/p1155), I would expect that you don't need `return std::move(E)` — `return E` should just as well perform "implicit move" in C++11 and later, assuming that `llvm::Expected<QualType>` has a valid constructor from `llvm::Error&&`.
You're not seeing any compiler diagnostic that //suggests// you use `std::move` here, are you?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73675/new/
https://reviews.llvm.org/D73675
More information about the cfe-commits
mailing list