[PATCH] D73642: [Clang][Bundler] Reduce fat object size

[Sergey Dmitriev via Phabricator via cfe-commits]

sdmitriev marked an inline comment as done.
sdmitriev added inline comments.


================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:378
+  // Creates temporary file with given contents.
+  Expected<StringRef> Create(Optional<ArrayRef<char>> Contents) {
+    SmallString<128u> File;
----------------
ABataev wrote:
> I see that Contents is either `None` or just one byte `0`. Maybe, better to use bool flag here instead of `Contents`?
Well, maybe we will need some other contents besides one zero byte in future, so I think having optional contents is probably better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73642/new/

https://reviews.llvm.org/D73642