[PATCH] D73642: [Clang][Bundler] Reduce fat object size

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:493-518
+    // Temporary files that need to be removed.
+    struct TempFileList : public SmallVector<SmallString<128u>, 2u> {
+      ~TempFileList() {
+        for (const auto &File : *this)
+          sys::fs::remove(File);
+        clear();
+      }
----------------
We usually don't do this. New types must be declared outside in anonymous namespaces. Also, better to use `part-of` inheritance rather than `is-a` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73642/new/

https://reviews.llvm.org/D73642