[PATCH] D73628: [clangd] Log directory when a CDB is loaded

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:122
+    if (Entry.CDB)
+      vlog("Loaded CDB from {0}", Dir);
   }
----------------
consider "Loaded compile commands..." or "Loading compile commands..." or "Loaded compilation database...".
People who are only dimly aware of the existence of `compile_commands.json` need a bit more context here.


================
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:122
+    if (Entry.CDB)
+      vlog("Loaded CDB from {0}", Dir);
   }
----------------
sammccall wrote:
> consider "Loaded compile commands..." or "Loading compile commands..." or "Loaded compilation database...".
> People who are only dimly aware of the existence of `compile_commands.json` need a bit more context here.
this is significant and rare, probably OK to log rather than vlog


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73628/new/

https://reviews.llvm.org/D73628